JAMES-1779 Make it clear we should requires authentication for downloadUrl
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/c9cbb88c Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/c9cbb88c Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/c9cbb88c Branch: refs/heads/master Commit: c9cbb88c0e5b54a8096b68628937179e8f2e8d5f Parents: c7e3d66 Author: Matthieu Baechler <matthieu.baech...@linagora.com> Authored: Wed Jun 22 16:00:47 2016 +0200 Committer: Antoine Duprat <adup...@linagora.com> Committed: Tue Jun 28 09:44:23 2016 +0200 ---------------------------------------------------------------------- .../jmap/cassandra/cucumber/CassandraDownloadCucumberTest.java | 3 ++- .../src/test/resources/cucumber/DownloadEndpoint.feature | 5 +++-- .../james/jmap/memory/cucumber/MemoryDownloadCucumberTest.java | 3 ++- 3 files changed, 7 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/james-project/blob/c9cbb88c/server/protocols/jmap-integration-testing/cassandra-jmap-integration-testing/src/test/java/org/apache/james/jmap/cassandra/cucumber/CassandraDownloadCucumberTest.java ---------------------------------------------------------------------- diff --git a/server/protocols/jmap-integration-testing/cassandra-jmap-integration-testing/src/test/java/org/apache/james/jmap/cassandra/cucumber/CassandraDownloadCucumberTest.java b/server/protocols/jmap-integration-testing/cassandra-jmap-integration-testing/src/test/java/org/apache/james/jmap/cassandra/cucumber/CassandraDownloadCucumberTest.java index 428d9df..9bbbdd2 100644 --- a/server/protocols/jmap-integration-testing/cassandra-jmap-integration-testing/src/test/java/org/apache/james/jmap/cassandra/cucumber/CassandraDownloadCucumberTest.java +++ b/server/protocols/jmap-integration-testing/cassandra-jmap-integration-testing/src/test/java/org/apache/james/jmap/cassandra/cucumber/CassandraDownloadCucumberTest.java @@ -26,6 +26,7 @@ import cucumber.api.junit.Cucumber; @RunWith(Cucumber.class) @CucumberOptions(features={"classpath:cucumber/DownloadEndpoint.feature", "classpath:cucumber/DownloadGet.feature"}, - glue={"org.apache.james.jmap.methods.integration", "org.apache.james.jmap.cassandra.cucumber"}) + glue={"org.apache.james.jmap.methods.integration", "org.apache.james.jmap.cassandra.cucumber"}, + tags = {"~@Ignore"}) public class CassandraDownloadCucumberTest { } http://git-wip-us.apache.org/repos/asf/james-project/blob/c9cbb88c/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature ---------------------------------------------------------------------- diff --git a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature index 6edcbc0..8d751a6 100644 --- a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature +++ b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature @@ -19,9 +19,10 @@ Feature: Download endpoint When asking for an attachment Then the user should be authorized - Scenario: An unauthenticated user should have access to the download endpoint + @Ignore + Scenario: An unauthenticated user should not have access to the download endpoint When asking for an attachment - Then the user should be authorized + Then the user should not be authorized Scenario: A known user should not have access to the download endpoint without a blobId Given a current user with username "usern...@domain.tld" and password "secret" http://git-wip-us.apache.org/repos/asf/james-project/blob/c9cbb88c/server/protocols/jmap-integration-testing/memory-jmap-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadCucumberTest.java ---------------------------------------------------------------------- diff --git a/server/protocols/jmap-integration-testing/memory-jmap-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadCucumberTest.java b/server/protocols/jmap-integration-testing/memory-jmap-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadCucumberTest.java index 3784393..509fdac 100644 --- a/server/protocols/jmap-integration-testing/memory-jmap-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadCucumberTest.java +++ b/server/protocols/jmap-integration-testing/memory-jmap-integration-testing/src/test/java/org/apache/james/jmap/memory/cucumber/MemoryDownloadCucumberTest.java @@ -26,6 +26,7 @@ import cucumber.api.junit.Cucumber; @RunWith(Cucumber.class) @CucumberOptions(features={"classpath:cucumber/DownloadEndpoint.feature", "classpath:cucumber/DownloadGet.feature"}, - glue={"org.apache.james.jmap.methods.integration", "org.apache.james.jmap.memory.cucumber"}) + glue={"org.apache.james.jmap.methods.integration", "org.apache.james.jmap.memory.cucumber"}, + tags = {"~@Ignore"}) public class MemoryDownloadCucumberTest { } --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
