[
https://issues.apache.org/jira/browse/JAMES-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15520874#comment-15520874
]
ASF GitHub Bot commented on JAMES-1823:
---------------------------------------
GitHub user chibenwa opened a pull request:
https://github.com/apache/james-project/pull/64
JAMES-1823 MailboxListenerRegistry should not register MailboxListene…
Here is my implementation for JAMES-1823, based on the findings and work of
https://github.com/leepaul21 he did on this pull request :
https://github.com/apache/james-project/pull/63
See https://github.com/linagora/james-project/pull/417 for integration
testing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chibenwa/james-project JAMES-1823
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/james-project/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 86d219fd808494dcd3fb4820b6d0e2e2721191be
Author: Benoit Tellier <[email protected]>
Date: 2016-09-25T13:55:59Z
JAMES-1823 MailboxListenerRegistry should not register MailboxListener twice
Provides tests for MailboxListenerRegistry
----
> quotaUpdater is invoked more than one time for a message addition or deletion
> -----------------------------------------------------------------------------
>
> Key: JAMES-1823
> URL: https://issues.apache.org/jira/browse/JAMES-1823
> Project: James Server
> Issue Type: Bug
> Components: MailStore & MailRepository
> Affects Versions: master
> Reporter: Paul Lee
> Fix For: master
>
> Attachments: DefaultDelegatingMailboxListener.java
>
>
> The following code snippet in 'init' method in 'StoreMailboxManager.java' is
> executed multiple times such that the same quotaUpdater is registered as a
> global listener more than once.
> if (quotaUpdater != null && quotaUpdater instanceof MailboxListener) {
> this.addGlobalListener((MailboxListener) quotaUpdater, null);
> }
> The above code is invoked multiple times by the below configuration in
> 'spring-mailbox.xml'.
> <import resource="classpath:META-INF/spring/mailbox-jpa.xml"/>
> <import resource="classpath:META-INF/spring/mailbox-maildir.xml"/>
> The quota increase or decrease is currently being executed twice for each
> message addition or deletion in our tests because the same quota updater is
> registered twice by the above config. For example, if a message of 1MB is
> appended to a mailbox, 'getCurrentStorage' method in
> 'InMemoryCurrentQuotaManager.java' returns a size which is 2MBs larger than
> before.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
