[ https://issues.apache.org/jira/browse/JAMES-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212649#comment-16212649 ]
ASF GitHub Bot commented on JAMES-2199: --------------------------------------- Github user dtrebbien commented on the issue: https://github.com/apache/james-project/pull/76 I created a new JIRA issue: https://issues.apache.org/jira/browse/JAMES-2199 > Improve usage of SLF4J > ---------------------- > > Key: JAMES-2199 > URL: https://issues.apache.org/jira/browse/JAMES-2199 > Project: James Server > Issue Type: Improvement > Reporter: Daniel Trebbien > Priority: Minor > > As suggested in the SLF4J FAQ (see > [https://www.slf4j.org/faq.html#logging_performance]) parameterized logging > can improve the efficiency of logger calls when logging at the specified > level is disabled. > When a value is formatted, toString() is called automatically: > [https://www.slf4j.org/faq.html#string_contents] > In addition, there are some cases where a format string has incorrect syntax, > or not enough format args are passed. This can lead to loss of data in the > logs. > There are some other cases where the result of String.format() or a string > buffer/builder are passed to a logger call. Parameterized logging can be used > even when an extra exception/throwable should be logged: > [https://www.slf4j.org/faq.html#paramException] > James Project uses SLF4J 1.7.25, which is affected by a regression introduced > in SLF4J 1.7.15. See: > [http://mailman.qos.ch/pipermail/slf4j-user/2017-August/001639.html] -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org