JAMES-2257 OldKeywords builder empty arguments are redundant
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/9d3bbbd3 Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/9d3bbbd3 Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/9d3bbbd3 Branch: refs/heads/master Commit: 9d3bbbd313a90352037fa7041e4869c5284b3b0a Parents: 71a6b1b Author: benwa <btell...@linagora.com> Authored: Tue Dec 12 16:29:59 2017 +0700 Committer: benwa <btell...@linagora.com> Committed: Fri Dec 15 14:03:32 2017 +0700 ---------------------------------------------------------------------- .../apache/james/jmap/model/OldKeywordTest.java | 69 -------------------- 1 file changed, 69 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/james-project/blob/9d3bbbd3/server/protocols/jmap/src/test/java/org/apache/james/jmap/model/OldKeywordTest.java ---------------------------------------------------------------------- diff --git a/server/protocols/jmap/src/test/java/org/apache/james/jmap/model/OldKeywordTest.java b/server/protocols/jmap/src/test/java/org/apache/james/jmap/model/OldKeywordTest.java index 46bdce4..7ef8625 100644 --- a/server/protocols/jmap/src/test/java/org/apache/james/jmap/model/OldKeywordTest.java +++ b/server/protocols/jmap/src/test/java/org/apache/james/jmap/model/OldKeywordTest.java @@ -40,11 +40,7 @@ public class OldKeywordTest { @Test public void asKeywordsShouldContainFlaggedWhenIsFlagged() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) .isFlagged(Optional.of(true)) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().asKeywords()) @@ -54,11 +50,7 @@ public class OldKeywordTest { @Test public void asKeywordsShouldNotContainFlaggedWhenIsNotFlagged() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) .isFlagged(Optional.of(false)) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().asKeywords()) @@ -69,10 +61,6 @@ public class OldKeywordTest { public void asKeywordsShouldNotContainSeenWhenIsUnRead() { Optional<OldKeyword> testee = OldKeyword.builder() .isUnread(Optional.of(true)) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().asKeywords()) @@ -83,10 +71,6 @@ public class OldKeywordTest { public void asKeywordsShouldContainSeenWhenIsRead() { Optional<OldKeyword> testee = OldKeyword.builder() .isUnread(Optional.of(false)) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); @@ -97,11 +81,7 @@ public class OldKeywordTest { @Test public void asKeywordsShouldContainAnsweredWhenIsAnswered() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) - .isFlagged(Optional.empty()) .isAnswered(Optional.of(true)) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().asKeywords()) @@ -111,11 +91,7 @@ public class OldKeywordTest { @Test public void asKeywordsShouldNotContainAnsweredWhenIsNotAnswered() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) - .isFlagged(Optional.empty()) .isAnswered(Optional.of(false)) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().asKeywords()) @@ -125,11 +101,7 @@ public class OldKeywordTest { @Test public void asKeywordsShouldContainDraftWhenIsDraft() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) .isDraft(Optional.of(true)) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().asKeywords()) @@ -139,11 +111,7 @@ public class OldKeywordTest { @Test public void asKeywordsShouldNotContainDraftWhenIsNotDraft() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) .isDraft(Optional.of(false)) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().asKeywords()) @@ -153,10 +121,6 @@ public class OldKeywordTest { @Test public void asKeywordsShouldContainForwardedWhenIsForwarded() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) .isForwarded(Optional.of(true)) .computeOldKeyword(); @@ -167,10 +131,6 @@ public class OldKeywordTest { @Test public void asKeywordsShouldNotContainForwardedWhenIsNotForwarded() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) .isForwarded(Optional.of(false)) .computeOldKeyword(); @@ -181,11 +141,6 @@ public class OldKeywordTest { @Test public void computeOldKeywordsShouldReturnEmptyWhenAllEmpty() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee).isEmpty(); @@ -194,11 +149,7 @@ public class OldKeywordTest { @Test public void applyStateShouldSetFlaggedOnlyWhenIsFlagged() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) .isFlagged(Optional.of(true)) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().applyToState(new Flags())).isEqualTo(new Flags(Flag.FLAGGED)); @@ -207,11 +158,7 @@ public class OldKeywordTest { @Test public void applyStateShouldRemoveFlaggedWhenEmptyIsFlaggedOnFlaggedMessage() { Optional<OldKeyword> testee = OldKeyword.builder() - .isUnread(Optional.empty()) .isFlagged(Optional.of(false)) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().applyToState(new Flags(Flag.FLAGGED))).isEqualTo(new Flags()); @@ -222,10 +169,6 @@ public class OldKeywordTest { public void applyStateShouldReturnUnreadFlagWhenUnreadSetOnSeenMessage() { Optional<OldKeyword> testee = OldKeyword.builder() .isUnread(Optional.of(true)) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().applyToState(new Flags(Flag.SEEN))).isEqualTo(new Flags()); @@ -235,10 +178,6 @@ public class OldKeywordTest { public void applyStateShouldReturnSeenWhenPatchSetsSeenOnSeenMessage() { Optional<OldKeyword> testee = OldKeyword.builder() .isUnread(Optional.of(false)) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().applyToState(new Flags(Flag.SEEN))).isEqualTo(new Flags(Flag.SEEN)); @@ -248,10 +187,6 @@ public class OldKeywordTest { public void applyStateShouldPreserveRecentFlag() { Optional<OldKeyword> testee = OldKeyword.builder() .isUnread(Optional.of(false)) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().applyToState(new Flags(Flag.RECENT))) @@ -262,10 +197,6 @@ public class OldKeywordTest { public void applyStateShouldPreserveDeletedFlag() { Optional<OldKeyword> testee = OldKeyword.builder() .isUnread(Optional.of(false)) - .isFlagged(Optional.empty()) - .isAnswered(Optional.empty()) - .isDraft(Optional.empty()) - .isForwarded(Optional.empty()) .computeOldKeyword(); assertThat(testee.get().applyToState(new Flags(Flag.DELETED))) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
