[ 
https://issues.apache.org/jira/browse/JAMES-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449449#comment-16449449
 ] 

ASF GitHub Bot commented on JAMES-2383:
---------------------------------------

Github user mbaechler commented on the issue:

    https://github.com/apache/james-project/pull/111
  
    Hi @provirus 
    
    Thank you for your contribution.
    
    The usual rule I try to follow concerning gitignore is : put in repository 
what relates to build tools and put in my local configuration what relates to 
my tools of choice.
    
    I'll quote git documentation (https://git-scm.com/docs/gitignore) here : 
    ```
    Which file to place a pattern in depends on how the pattern is meant to be 
used.
    
        Patterns which should be version-controlled and distributed to other 
repositories via clone (i.e., files that all developers will want to ignore) 
should go into a .gitignore file.
    
        Patterns which are specific to a particular repository but which do not 
need to be shared with other related repositories (e.g., auxiliary files that 
live inside the repository but are specific to one user’s workflow) should go 
into the $GIT_DIR/info/exclude file.
    
        Patterns which a user wants Git to ignore in all situations (e.g., 
backup or temporary files generated by the user’s editor of choice) generally 
go into a file specified by core.excludesFile in the user’s ~/.gitconfig. Its 
default value is $XDG_CONFIG_HOME/git/ignore. If $XDG_CONFIG_HOME is either not 
set or empty, $HOME/.config/git/ignore is used instead.
    ```
    
    Would you mind fixing the PR accordingly ?


> Missing ignore for Eclipse and Maven generated files
> ----------------------------------------------------
>
>                 Key: JAMES-2383
>                 URL: https://issues.apache.org/jira/browse/JAMES-2383
>             Project: James Server
>          Issue Type: Improvement
>          Components: James Core
>    Affects Versions: master
>            Reporter: Simon Levesque
>            Priority: Trivial
>
> When importing in Eclipse and when compiling with Maven, there are a lot of 
> files that wants to be included
>  
> {noformat}
> .settings/
> backends-common/.settings/
> backends-common/cassandra/.classpath
> backends-common/cassandra/.project
> backends-common/cassandra/.settings/
> backends-common/cassandra/target/
> backends-common/elasticsearch/.classpath
> backends-common/elasticsearch/.project
> backends-common/elasticsearch/.settings/
> backends-common/elasticsearch/target/
> backends-common/jpa/.classpath
> backends-common/jpa/.project
> backends-common/jpa/.settings/
> backends-common/jpa/target/
> backends-common/target/
> core/.classpath
> core/.project
> core/.settings/
> core/target/
> javax-mail-extension/.classpath
> javax-mail-extension/.project
> javax-mail-extension/.settings/
> javax-mail-extension/target/
> mailbox/.settings/
> mailbox/api/.classpath
> mailbox/api/.project
> mailbox/api/.settings/
> mailbox/api/target/
> mailbox/caching/.classpath
> mailbox/caching/.project
> mailbox/caching/.settings/
> mailbox/caching/target/
> mailbox/cassandra/.classpath
> mailbox/cassandra/.project
> mailbox/cassandra/.settings/
> mailbox/cassandra/target/
> mailbox/hbase/.classpath
> mailbox/hbase/.project
> mailbox/hbase/.settings/
> mailbox/hbase/target/
> mailbox/jcr/.classpath
> mailbox/jcr/.project
> mailbox/jcr/.settings/
> mailbox/jcr/target/
> mailbox/jpa/.classpath
> mailbox/jpa/.project
> mailbox/jpa/.settings/
> mailbox/jpa/target/
> mailbox/kafka/.classpath
> mailbox/kafka/.project
> mailbox/kafka/.settings/
> mailbox/kafka/target/
> mailbox/lucene/.classpath
> mailbox/lucene/.project
> mailbox/lucene/.settings/
> mailbox/lucene/target/
> mailbox/maildir/.classpath
> mailbox/maildir/.project
> mailbox/maildir/.settings/
> mailbox/maildir/target/
> mailbox/memory/.classpath
> mailbox/memory/.project
> mailbox/memory/.settings/
> mailbox/memory/target/
> mailbox/plugin/spamassassin/.classpath
> mailbox/plugin/spamassassin/.project
> mailbox/plugin/spamassassin/.settings/
> mailbox/plugin/spamassassin/target/
> mailbox/scanning-search/.classpath
> mailbox/scanning-search/.project
> mailbox/scanning-search/.settings/
> mailbox/scanning-search/target/
> mailbox/spring/.classpath
> mailbox/spring/.project
> mailbox/spring/.settings/
> mailbox/spring/target/
> mailbox/store/.classpath
> mailbox/store/.project
> mailbox/store/.settings/
> mailbox/store/target/
> mailbox/target/
> mailbox/tika/.classpath
> mailbox/tika/.project
> mailbox/tika/.settings/
> mailbox/tika/target/
> mailbox/tool/.classpath
> mailbox/tool/.project
> mailbox/tool/.settings/
> mailbox/tool/target/
> mailbox/zoo-seq-provider/.classpath
> mailbox/zoo-seq-provider/.project
> mailbox/zoo-seq-provider/.settings/
> mailbox/zoo-seq-provider/target/
> mailet/.settings/
> mailet/ai/.classpath
> mailet/ai/.project
> mailet/ai/.settings/
> mailet/api/.classpath
> mailet/api/.project
> mailet/api/.settings/
> mailet/base/.classpath
> mailet/base/.project
> mailet/base/.settings/
> mailet/crypto/.classpath
> mailet/crypto/.project
> mailet/crypto/.settings/
> mailet/icalendar/.classpath
> mailet/icalendar/.project
> mailet/icalendar/.settings/
> mailet/mailetdocs-maven-plugin/.classpath
> mailet/mailetdocs-maven-plugin/.project
> mailet/mailetdocs-maven-plugin/.settings/
> mailet/standard/.classpath
> mailet/standard/.project
> mailet/standard/.settings/
> mdn/.classpath
> mdn/.project
> mdn/.settings/
> mdn/target/
> metrics/.settings/
> metrics/metrics-api/.classpath
> metrics/metrics-api/.project
> metrics/metrics-api/.settings/
> metrics/metrics-api/target/
> metrics/metrics-dropwizard/.classpath
> metrics/metrics-dropwizard/.project
> metrics/metrics-dropwizard/.settings/
> metrics/metrics-dropwizard/target/
> metrics/metrics-logger/.classpath
> metrics/metrics-logger/.project
> metrics/metrics-logger/.settings/
> metrics/metrics-logger/target/
> metrics/target/
> mpt/app/dependency-reduced-pom.xml
> protocols/.settings/
> protocols/api/.classpath
> protocols/api/.project
> protocols/api/.settings/
> protocols/imap/.classpath
> protocols/imap/.project
> protocols/imap/.settings/
> protocols/lmtp/.classpath
> protocols/lmtp/.project
> protocols/lmtp/.settings/
> protocols/managesieve/.classpath
> protocols/managesieve/.project
> protocols/managesieve/.settings/
> protocols/netty/.classpath
> protocols/netty/.project
> protocols/netty/.settings/
> protocols/pop3/.classpath
> protocols/pop3/.project
> protocols/pop3/.settings/
> protocols/smtp/.classpath
> protocols/smtp/.project
> protocols/smtp/.settings/
> protocols/smtp/dependency-reduced-pom.xml
> target/{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to