[ 
https://issues.apache.org/jira/browse/JAMES-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454002#comment-16454002
 ] 

ASF GitHub Bot commented on JAMES-2343:
---------------------------------------

Github user chikei commented on the issue:

    https://github.com/apache/james-project/pull/105
  
    I just find out I made mistake yesterday that a simple flush during 
`MimeMessageInputStreamSource(String key, InputStream in)` is not enough 
because the code path originally I concerned was 
`MimeMessageInputStreamSource(String key)` followed by 
`MimeMessageInputStreamSource.getWritableOutputStream`.
    
    I'll bring original patch back and add the tests from common-io then run 
the benchmark again to ensure the the improvement.


> Use buffered file output stream for MimeMessageInputStreamSource
> ----------------------------------------------------------------
>
>                 Key: JAMES-2343
>                 URL: https://issues.apache.org/jira/browse/JAMES-2343
>             Project: James Server
>          Issue Type: Improvement
>          Components: James Core
>            Reporter: TzeKai Lee
>            Priority: Major
>
> Currently MimeMessageInputStreamSource use DeferredFileOutputStream from 
> commons-io which does _not_ buffer output stream when switched to 
> FileOutputStream. In my preliminary test, simply wrap FileOutputStream with 
> BufferedOutputStream could make a 50% performance improvement for mail larger 
> than deferring threshold (currently 100kb).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to