[
https://issues.apache.org/jira/browse/JAMES-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518904#comment-16518904
]
ASF GitHub Bot commented on JAMES-2279:
---------------------------------------
Github user chibenwa commented on the issue:
https://github.com/apache/james-project/pull/121
Hi, one more comment:
We do use 4 space indetation, but your contribution uses TAB, generating
this checkstyle violation:
```
[a2a6df63a568fb6eb5cda5d4676057d198564e0b] [INFO] There are 3 errors
reported by Checkstyle 8.5 with checkstyle.xml ruleset.
[a2a6df63a568fb6eb5cda5d4676057d198564e0b] [ERROR]
src/main/java/org/apache/james/transport/mailets/WithPriority.java:[26]
(imports) CustomImportOrder: Import statement for
'javax.mail.MessagingException' is in the wrong order. Should be in the
'STANDARD_JAVA_PACKAGE' group, expecting not assigned imports on this line.
[a2a6df63a568fb6eb5cda5d4676057d198564e0b] [ERROR]
src/main/java/org/apache/james/transport/mailets/WithPriority.java:[27]
(imports) CustomImportOrder: Import statement for 'java.util.Optional' is in
the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group, expecting not
assigned imports on this line.
[a2a6df63a568fb6eb5cda5d4676057d198564e0b] [ERROR]
src/main/java/org/apache/james/transport/mailets/WithPriority.java:[60,5]
(whitespace) FileTabCharacter: Line contains a tab character.
```
Could you remove TAB and use 4 spaces instead?
> Write a WithPriority mailet and HasPriority matchers
> ----------------------------------------------------
>
> Key: JAMES-2279
> URL: https://issues.apache.org/jira/browse/JAMES-2279
> Project: James Server
> Issue Type: New Feature
> Components: Mailet Contributions
> Affects Versions: master
> Reporter: Tellier Benoit
> Priority: Major
> Labels: easyfix, feature, newbie
>
> James mail queues is handling mail priorities. See the *MailPrioritySupport*
> interface.
> This is done using the MAIL_PRIORITY mail attribute. It is an integer
> property ranging from 0 (low) to 9 (high) and mail queue component will
> default to 5.
> Today, the mail processing unit akka mailetContainer can not change the
> priority set by the SMTP layer (using *MailPriorityHandler*). This is a
> problem as we can not re-prioritise outgoing emails, for instance in remote
> delivery queues.
> I would thus propose the following mailet:
> {code:xml}
> <mailet matcher="All" class="WithPriority">
> <value>8</value>
> </mailet>
> {code}
> Furthermore, we might want to customize processing logic depending on the
> priority (might it just be for debugging purpose).
> To do so, I propose to introduce the following matchers:
> {code:xml}
> <mailet matcher="HasPriority=8" class="Any"/>
> <mailet matcher="AtLeastPriority=8" class="Any"/>
> <mailet matcher="AtMostPriority=8" class="Any"/>
> {code}
> *How to do this?*
> In the `server/mailet/mailets` project, in the mailet package create the
> WithPriority mailet which sets the MAIL_PRIORITY attribute.
> Create the matchers in `server/mailet/mailets` in the matcher package.
> Write unit tests for these mailets / matchers.
> Use MailetUtil content to parse the integer conditions/value. You can reuse
> https://github.com/linagora/james-project/pull/1215 to ease your work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
