JAMES-2557 Explicitly add preconditions in FakeMail#Builder
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/dbb6074b Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/dbb6074b Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/dbb6074b Branch: refs/heads/master Commit: dbb6074b996ef9529cd257fb4cc0b3a7371c9899 Parents: aaf1767 Author: Benoit Tellier <[email protected]> Authored: Thu Oct 25 13:52:43 2018 +0700 Committer: Benoit Tellier <[email protected]> Committed: Tue Oct 30 09:39:09 2018 +0700 ---------------------------------------------------------------------- .../src/main/java/org/apache/mailet/base/test/FakeMail.java | 9 +++++++++ 1 file changed, 9 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/james-project/blob/dbb6074b/mailet/test/src/main/java/org/apache/mailet/base/test/FakeMail.java ---------------------------------------------------------------------- diff --git a/mailet/test/src/main/java/org/apache/mailet/base/test/FakeMail.java b/mailet/test/src/main/java/org/apache/mailet/base/test/FakeMail.java index 895256e..43281a8 100644 --- a/mailet/test/src/main/java/org/apache/mailet/base/test/FakeMail.java +++ b/mailet/test/src/main/java/org/apache/mailet/base/test/FakeMail.java @@ -124,16 +124,19 @@ public class FakeMail implements Mail, Serializable { } public Builder fileName(String fileName) { + Preconditions.checkNotNull(fileName,"'fileName' can not be null"); this.fileName = Optional.of(fileName); return this; } public Builder mimeMessage(MimeMessage mimeMessage) { + Preconditions.checkNotNull(mimeMessage, "'mimeMessage' can not be null"); this.mimeMessage = Optional.of(mimeMessage); return this; } public Builder mimeMessage(MimeMessageBuilder mimeMessage) throws MessagingException { + Preconditions.checkNotNull(mimeMessage, "'mimeMessage' can not be null"); this.mimeMessage = Optional.of(mimeMessage.build()); return this; } @@ -152,6 +155,7 @@ public class FakeMail implements Mail, Serializable { } public Builder recipients(String... recipients) { + Preconditions.checkNotNull(recipients, "'recipients' can not be null"); return recipients(Arrays.stream(recipients) .map(Throwing.function(MailAddress::new)) .collect(Guavate.toImmutableList())); @@ -166,11 +170,13 @@ public class FakeMail implements Mail, Serializable { } public Builder name(String name) { + Preconditions.checkNotNull(name, "'name' can not be null"); this.name = Optional.of(name); return this; } public Builder sender(MailAddress sender) { + Preconditions.checkNotNull(sender, "'sender' can not be null"); this.sender = Optional.of(sender); return this; } @@ -180,16 +186,19 @@ public class FakeMail implements Mail, Serializable { } public Builder state(String state) { + Preconditions.checkNotNull(state, "'state' can not be null"); this.state = Optional.of(state); return this; } public Builder errorMessage(String errorMessage) { + Preconditions.checkNotNull(errorMessage, "'errorMessage' can not be null"); this.errorMessage = Optional.of(errorMessage); return this; } public Builder lastUpdated(Date lastUpdated) { + Preconditions.checkNotNull(lastUpdated, "'lastUpdated' can not be null"); this.lastUpdated = Optional.of(lastUpdated); return this; } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
