[
https://issues.apache.org/jira/browse/JAMES-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730137#comment-16730137
]
ASF GitHub Bot commented on JAMES-2171:
---------------------------------------
Github user chibenwa commented on a diff in the pull request:
https://github.com/apache/james-project/pull/145#discussion_r244283656
--- Diff:
mailet/test/src/main/java/org/apache/mailet/base/test/FakeMailetConfig.java ---
@@ -76,22 +74,33 @@ public FakeMailetConfig build() {
private final String mailetName;
private final MailetContext mailetContext;
- private final Properties properties;
+ private final Map<String, Object> properties;
- private FakeMailetConfig(String mailetName, MailetContext
mailetContext, Properties properties) {
+ private FakeMailetConfig(String mailetName, MailetContext
mailetContext, Map properties) {
this.mailetName = mailetName;
this.mailetContext = mailetContext;
this.properties = properties;
}
+ @Override
+ public <T> T getInitParameter(String name, Class<T> clazz) {
+ Object o = properties.get(name);
+ if (o != null) {
+ if (clazz.isInstance(o)) {
+ return (T) properties.get(name);
+ } else throw new ClassCastException(name + " property is not
of type " + clazz.getCanonicalName());
+ } else return null;
--- End diff --
You need an explicit `{}` block
> LogMessage mailet improvments
> -----------------------------
>
> Key: JAMES-2171
> URL: https://issues.apache.org/jira/browse/JAMES-2171
> Project: James Server
> Issue Type: Improvement
> Components: Mailet Contributions
> Affects Versions: master
> Reporter: Tellier Benoit
> Priority: Major
> Labels: easyfix, newbie
>
> Today, one can use the LogMessage to generate log messages upon mail reception
> But the LogMessage have the following limits:
> - It do not let you configure the warn level
> - It does generate several logs. One would be simpler to review.
> - It does add some unneeded informations, like mail name already carried by
> the MDC
> - It does not allow logging of specific headers or specific attributeNames.
> This leads to missing information as well as "to much information".
> - The code quality of the mailet is poor.
> You will:
> - Ensure a single log message will be generated. For this you will call the
> logger one time and concatenate log messages parts.
> - Remove the log line with mail name.
> - Add a **level** configuration option. It can takes value **warn**,
> **info**, **debug** or **error**. It will be used to set the logger log level.
> - Add a **specificHeaders** configuration option. It takes a comma separated
> list of header names to include in the log message. By default it is empty.
> - Add a **specificAttributes** configuration option. It takes a comma
> separated list of attribute names to be included in the log message. By
> default it is empty.
> - **body** configuration option should be false by default
> - **header** configuration option should be false by default
> - **init** should propagate exception while initilizing (Integer parse
> exception, also passing a negative max body should throw.)
> - Remove inlined affectation for field. They can be unset on their
> declaration and set when init is called.
> Correct *LogMessageTest* accordingly.
> Don't hesitate to reach us on the *gitter* chat if you have any question.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
