[
https://issues.apache.org/jira/browse/JAMES-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jörg Thomas (ConSol) updated JAMES-2929:
----------------------------------------
Description:
The table structure as defined in {{sqlResources.xml}} and the corresponding
JDBC code in
{{server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java}}
have diverged since the fix for
[JAMES-2303|https://issues.apache.org/jira/browse/JAMES-2303]. There's three
issues:
* these SQL resources were left unmodified:
** {{dockerfiles/run/spring/destination/conf/sqlResources.xml}}
** {{server/app/src/main/resources/sqlResources.xml}}
** {{server/data/data-jdbc/src/test/resources/sqlResources-mail.xml}}
* the order in {{server/data/data-jdbc/src/test/resources/sqlResources.xml}}
is wrong:
** message_body (SQL index: 9, JDBC index: 11)
** message_attributes (SQL index: 10, JDBC index: 12)
** per_recipient_headers (SQL index: 11, JDBC index: 9)
** last_updated timestamp (SQL index: 12, JDBC index: 10)
* Since this went completely unnoticed for quite some time, adding tests would
be appropriate?
There is a fourth issue which -I will bring up when the above issues are
adressed.- is already filed here under
[JAMES-2828|https://issues.apache.org/jira/browse/JAMES-2828].
was:
The table structure as defined in {{sqlResources.xml}} and the corresponding
JDBC code in
{{server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java}}
have diverged since the fix for
[JAMES-2303|https://issues.apache.org/jira/browse/JAMES-2303]. There's three
issues:
* {{server/app/src/main/resources/sqlResources.xml}} and
{{dockerfiles/run/spring/destination/conf/sqlResources.xml}} were left
unmodified
** [EDIT] `sqlResources-mail.xml` need to be changed as well
* the order in {{server/data/data-jdbc/src/test/resources/sqlResources.xml}}
is wrong:
** message_body (SQL index: 9, JDBC index: 11)
** message_attributes (SQL index: 10, JDBC index: 12)
** per_recipient_headers (SQL index: 11, JDBC index: 9)
** last_updated timestamp (SQL index: 12, JDBC index: 10)
* Since this went completely unnoticed for quite some time, adding tests would
be appropriate?
There is a fourth issue which -I will bring up when the above issues are
adressed.- is already filed here under
[JAMES-2828|https://issues.apache.org/jira/browse/JAMES-2828].
> JDBCMailRepository broken: SQL and JDBC code out of sync
> --------------------------------------------------------
>
> Key: JAMES-2929
> URL: https://issues.apache.org/jira/browse/JAMES-2929
> Project: James Server
> Issue Type: Bug
> Components: JDBC, MailStore & MailRepository
> Affects Versions: 3.2.0, 3.3.0, 3.4.0, 3.3.1
> Reporter: Jörg Thomas (ConSol)
> Priority: Major
> Fix For: 3.5.0
>
>
> The table structure as defined in {{sqlResources.xml}} and the corresponding
> JDBC code in
> {{server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java}}
> have diverged since the fix for
> [JAMES-2303|https://issues.apache.org/jira/browse/JAMES-2303]. There's three
> issues:
> * these SQL resources were left unmodified:
> ** {{dockerfiles/run/spring/destination/conf/sqlResources.xml}}
> ** {{server/app/src/main/resources/sqlResources.xml}}
> ** {{server/data/data-jdbc/src/test/resources/sqlResources-mail.xml}}
> * the order in {{server/data/data-jdbc/src/test/resources/sqlResources.xml}}
> is wrong:
> ** message_body (SQL index: 9, JDBC index: 11)
> ** message_attributes (SQL index: 10, JDBC index: 12)
> ** per_recipient_headers (SQL index: 11, JDBC index: 9)
> ** last_updated timestamp (SQL index: 12, JDBC index: 10)
> * Since this went completely unnoticed for quite some time, adding tests
> would be appropriate?
> There is a fourth issue which -I will bring up when the above issues are
> adressed.- is already filed here under
> [JAMES-2828|https://issues.apache.org/jira/browse/JAMES-2828].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
