[james-project] 08/32: [Refactoring] StatusProcessor: Extract metadata retrieval

[btellier]

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit db0248d927bf56997a095d3a16fb7a54079ea1e3
Author: Benoit Tellier <btell...@linagora.com>
AuthorDate: Wed Nov 13 11:30:22 2019 +0700

    [Refactoring] StatusProcessor: Extract metadata retrieval
---
 .../java/org/apache/james/imap/processor/StatusProcessor.java  | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git 
a/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
 
b/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
index 00cddea..0486f36 100644
--- 
a/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
+++ 
b/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
@@ -60,9 +60,7 @@ public class StatusProcessor extends 
AbstractMailboxProcessor<StatusRequest> {
         try {
             LOGGER.debug("Status called on mailbox named {}", mailboxPath);
 
-            MessageManager mailbox = 
getMailboxManager().getMailbox(mailboxPath, 
ImapSessionUtils.getMailboxSession(session));
-            MessageManager.MetaData.FetchGroup fetchGroup = 
computeFetchGroup(statusDataItems);
-            MessageManager.MetaData metaData = mailbox.getMetaData(false, 
mailboxSession, fetchGroup);
+            MessageManager.MetaData metaData = retrieveMetadata(mailboxPath, 
statusDataItems, mailboxSession);
             MailboxStatusResponse response = computeStatusResponse(request, 
statusDataItems, metaData);
 
             // Enable CONDSTORE as this is a CONDSTORE enabling command
@@ -78,6 +76,12 @@ public class StatusProcessor extends 
AbstractMailboxProcessor<StatusRequest> {
         }
     }
 
+    private MessageManager.MetaData retrieveMetadata(MailboxPath mailboxPath, 
StatusDataItems statusDataItems, MailboxSession mailboxSession) throws 
MailboxException {
+        MessageManager mailbox = getMailboxManager().getMailbox(mailboxPath, 
mailboxSession);
+        MessageManager.MetaData.FetchGroup fetchGroup = 
computeFetchGroup(statusDataItems);
+        return mailbox.getMetaData(false, mailboxSession, fetchGroup);
+    }
+
     private MailboxStatusResponse computeStatusResponse(StatusRequest request, 
StatusDataItems statusDataItems, MessageManager.MetaData metaData) {
         Long messages = messages(statusDataItems, metaData);
         Long recent = recent(statusDataItems, metaData);


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org