This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit ca518e6e2db7066e31298e57af3ad0628c470779 Author: Benoit Tellier <btell...@linagora.com> AuthorDate: Mon Dec 2 16:52:28 2019 +0700 JAMES-2979 Disable FileMailQueue tests --- .../james/queue/file/FileMailQueueFactoryTest.java | 7 +++ .../apache/james/queue/file/FileMailQueueTest.java | 70 ++-------------------- 2 files changed, 13 insertions(+), 64 deletions(-) diff --git a/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueFactoryTest.java b/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueFactoryTest.java index 4dc1ebf..926092f 100644 --- a/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueFactoryTest.java +++ b/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueFactoryTest.java @@ -27,7 +27,14 @@ import org.apache.james.queue.api.ManageableMailQueueFactoryContract; import org.apache.james.queue.api.RawMailQueueItemDecoratorFactory; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; +@Disabled("FileMailQueue is an outdated unmaintained component suffering incomplete features and is not thread safe" + + "This includes: " + + " - JAMES-2298 Unsupported remove management feature" + + " - JAMES-2954 Incomplete browse implementation" + + " - JAMES-2544 Mixing concurrent operation might lead to a deadlock and missing fields" + + " - JAMES-2979 dequeue is not thread safe") public class FileMailQueueFactoryTest implements MailQueueFactoryContract<ManageableMailQueue>, ManageableMailQueueFactoryContract { private FileMailQueueFactory mailQueueFactory; private MockFileSystem fileSystem; diff --git a/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueTest.java b/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueTest.java index bfc9bd7..f2659d6 100644 --- a/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueTest.java +++ b/server/queue/queue-file/src/test/java/org/apache/james/queue/file/FileMailQueueTest.java @@ -26,9 +26,14 @@ import org.apache.james.queue.api.RawMailQueueItemDecoratorFactory; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Disabled; -import org.junit.jupiter.api.Test; import org.junit.rules.TemporaryFolder; +@Disabled("FileMailQueue is an outdated unmaintained component suffering incomplete features and is not thread safe" + + "This includes: " + + " - JAMES-2298 Unsupported remove management feature" + + " - JAMES-2954 Incomplete browse implementation" + + " - JAMES-2544 Mixing concurrent operation might lead to a deadlock and missing fields" + + " - JAMES-2979 dequeue is not thread safe") public class FileMailQueueTest implements DelayedManageableMailQueueContract { private static final boolean SYNC = true; @@ -55,67 +60,4 @@ public class FileMailQueueTest implements DelayedManageableMailQueueContract { public ManageableMailQueue getManageableMailQueue() { return mailQueue; } - - @Test - @Override - @Disabled("JAMES-2298 Not supported yet") - public void removeBySenderShouldRemoveSpecificEmail() { - - } - - @Test - @Override - @Disabled("JAMES-2298 Not supported yet") - public void removeByNameShouldRemoveSpecificEmail() { - - } - - @Test - @Override - @Disabled("JAMES-2298 Not supported yet") - public void removeByRecipientShouldRemoveSpecificEmail() { - - } - - @Test - @Override - @Disabled("JAMES-2298 Not supported yet") - public void removeByRecipientShouldNotFailWhenQueueIsEmpty() { - - } - - @Test - @Override - @Disabled("JAMES-2298 Not supported yet") - public void removeBySenderShouldNotFailWhenQueueIsEmpty() { - - } - - @Test - @Override - @Disabled("JAMES-2298 Not supported yet") - public void removeByRecipientShouldRemoveSpecificEmailWhenMultipleRecipients() { - - } - - @Test - @Override - @Disabled("JAMES-2544 Not supported yet") - public void browseShouldReturnMailsWithMimeMessage() { - - } - - @Test - @Override - @Disabled("JAMES-2544 Mixing concurent operation might lead to a deadlock and missing fiels") - public void concurrentEnqueueDequeueWithAckNackShouldNotFail() { - - } - - @Test - @Override - @Disabled("JAMES-2544 Not supported yet") - public void deletedElementsShouldNotBeDequeued() { - - } } --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org