This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 03103018aefc1885f479b01f7df7c31e0d42e682 Author: Raphael Ouazana <[email protected]> AuthorDate: Wed Jul 8 10:32:50 2020 +0200 JAMES-3300 set useConnectionPool to false by default --- .../apache/james/user/ldap/LdapRepositoryConfiguration.java | 6 +++--- upgrade-instructions.md | 12 ++++++++++++ 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/server/data/data-ldap/src/main/java/org/apache/james/user/ldap/LdapRepositoryConfiguration.java b/server/data/data-ldap/src/main/java/org/apache/james/user/ldap/LdapRepositoryConfiguration.java index 127fe02..f526cd2 100644 --- a/server/data/data-ldap/src/main/java/org/apache/james/user/ldap/LdapRepositoryConfiguration.java +++ b/server/data/data-ldap/src/main/java/org/apache/james/user/ldap/LdapRepositoryConfiguration.java @@ -32,7 +32,7 @@ import com.google.common.base.Preconditions; public class LdapRepositoryConfiguration { public static final String SUPPORTS_VIRTUAL_HOSTING = "supportsVirtualHosting"; - private static final boolean USE_CONNECTION_POOL = true; + private static final boolean NO_CONNECTION_POOL = false; private static final int NO_CONNECTION_TIMEOUT = -1; private static final int NO_READ_TIME_OUT = -1; private static final boolean ENABLE_VIRTUAL_HOSTING = true; @@ -134,7 +134,7 @@ public class LdapRepositoryConfiguration { userBase.get(), userIdAttribute.get(), userObjectClass.get(), - USE_CONNECTION_POOL, + NO_CONNECTION_POOL, NO_CONNECTION_TIMEOUT, NO_READ_TIME_OUT, maxRetries.get(), @@ -160,7 +160,7 @@ public class LdapRepositoryConfiguration { String userIdAttribute = configuration.getString("[@userIdAttribute]"); String userObjectClass = configuration.getString("[@userObjectClass]"); // Default is to use connection pooling - boolean useConnectionPool = configuration.getBoolean("[@useConnectionPool]", USE_CONNECTION_POOL); + boolean useConnectionPool = configuration.getBoolean("[@useConnectionPool]", NO_CONNECTION_POOL); int connectionTimeout = configuration.getInt("[@connectionTimeout]", NO_CONNECTION_TIMEOUT); int readTimeout = configuration.getInt("[@readTimeout]", NO_READ_TIME_OUT); // Default maximum retries is 1, which allows an alternate connection to diff --git a/upgrade-instructions.md b/upgrade-instructions.md index a1171f4..6857221 100644 --- a/upgrade-instructions.md +++ b/upgrade-instructions.md @@ -35,6 +35,18 @@ Change list: - [Log4J2 Adoption](#log4j2-adoption) - [Drop Cassandra schema version prior version 5](#drop-cassandra-schema-version-prior-version-5) - [mailqueue.size.metricsEnabled now defaults to false](#mailqueuesizemetricsenabled-now-defaults-to-false) + - [LDAP users repository connection pool now defaults to false](#ldap-users-repository-connection-pool-now-defaults-to-false) + +### LDAP users repository connection pool now defaults to false + +Date 08/07/2020 + +JIRA: https://issues.apache.org/jira/browse/JAMES-3300 + +Concerned product: all products relying on LDAP users repository + +`useConnectionPool` is now false by default. If you really want it, you have to explicitely put it to `true` in `usersrepository.xml`. +It is false by default because it can create too much connections on the LDAP server. If you have few users it can eventually still make sense. ### mailqueue.size.metricsEnabled now defaults to false --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
