[ https://issues.apache.org/jira/browse/JAMES-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174035#comment-17174035 ]
René Cordier commented on JAMES-3316: ------------------------------------- [https://github.com/linagora/james-project/pull/3644] fixed a buggy test with SessionRoutesTest > Configure session hardcoded prefixes > ------------------------------------ > > Key: JAMES-3316 > URL: https://issues.apache.org/jira/browse/JAMES-3316 > Project: James Server > Issue Type: Improvement > Components: JMAP > Reporter: Nguyễn Việt Đức > Priority: Major > > WHY > In SessionSupplier.scala: > > {code:java} > apiUrl = new URL(s"$HARD_CODED_URL_PREFIX/jmap"), > downloadUrl = new URL(s"$HARD_CODED_URL_PREFIX/download"), > uploadUrl = new URL(s"$HARD_CODED_URL_PREFIX/upload"), > eventSourceUrl = new URL(s"$HARD_CODED_URL_PREFIX/eventSource"))) > {code} > We hard coded with a costant the URL prefix for JMAP service endpoint > advertised via the session object. > This of course should be adapted to the running server domain/URL > How > We should be able to parse and configure this prefix reading jmap.properties > DOD We should be able to get HARD_CODED_URL_PREFIX from JMAP server > configuration. > Write (or adapt) an integration test where the session route relies on the > configured parameters. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org