[ 
https://issues.apache.org/jira/browse/JAMES-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232741#comment-17232741
 ] 

ASF GitHub Bot commented on JAMES-1902:
---------------------------------------

chibenwa commented on a change in pull request #261:
URL: https://github.com/apache/james-project/pull/261#discussion_r524253411



##########
File path: server/container/guice/blob/blob-api-guice/pom.xml
##########
@@ -25,7 +25,7 @@
         <groupId>org.apache.james</groupId>
         <artifactId>james-server-guice</artifactId>
         <version>3.6.0-SNAPSHOT</version>
-        <relativePath>../pom.xml</relativePath>
+        <relativePath>../../pom.xml</relativePath>

Review comment:
       Does it makes sense to keep the blob- prefix for folders inside a blob 
directory? Idem for the guice suffix.
   
   Shouldn't the naming scheme be guice/blob/api ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> It should be possible to build a custom server without importing all guice 
> modules
> ----------------------------------------------------------------------------------
>
>                 Key: JAMES-1902
>                 URL: https://issues.apache.org/jira/browse/JAMES-1902
>             Project: James Server
>          Issue Type: Improvement
>          Components: guice
>            Reporter: Matthieu Baechler
>            Priority: Major
>
> I'd like to be able to build an smtp only server without importing stuff 
> related to other protocols and features.
> Or lmtp + imap + mailbox.
> Any valid combination should be possible.
> For that, we need to create as many guice sub-projects as needed and split 
> current guice-common into pieces.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to