[
https://issues.apache.org/jira/browse/JAMES-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247685#comment-17247685
]
ASF GitHub Bot commented on JAMES-3431:
---------------------------------------
chibenwa commented on a change in pull request #278:
URL: https://github.com/apache/james-project/pull/278#discussion_r540720313
##########
File path:
protocols/smtp/src/main/java/org/apache/james/protocols/smtp/hook/HeloHook.java
##########
@@ -19,12 +19,19 @@
package org.apache.james.protocols.smtp.hook;
+import java.util.Set;
+
import org.apache.james.protocols.smtp.SMTPSession;
+import com.google.common.collect.ImmutableSet;
+
/**
* Implement this interfaces to hook in the HELO Command
*/
public interface HeloHook extends Hook {
+ default Set<String> implementedEsmtpFeatures() {
Review comment:
We need Java Doc here!
##########
File path:
protocols/smtp/src/main/java/org/apache/james/protocols/smtp/hook/RcptHook.java
##########
@@ -51,4 +62,8 @@ default HookResult doRcpt(SMTPSession session, MaybeSender
sender, MailAddress r
return doRcpt(session, sender.asOptional().orElse(null), rcpt);
}
+ default HookResult doRcpt(SMTPSession session, MaybeSender sender,
MailAddress rcpt, Map<String, String> parameters) {
Review comment:
We need Java doc here!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Relay DSN options on RemoteDelivery
> -----------------------------------
>
> Key: JAMES-3431
> URL: https://issues.apache.org/jira/browse/JAMES-3431
> Project: James Server
> Issue Type: Bug
> Components: Remote Delivery, SMTPServer
> Affects Versions: 3.5.0
> Reporter: Karsten Otto
> Priority: Major
>
> Since James claims to support the DSN SMTP extension, it may receive a mail
> submission according to [RFC 3461|https://tools.ietf.org/html/rfc3461]:
> {code:java}
> MAIL FROM:<[email protected]> RET=HDRS ENVID=QQ314159
> RCPT TO:<[email protected]> NOTIFY=SUCCESS,FAILURE,DELAY
> ORCPT=rfc822;[email protected]
> RCPT TO:<[email protected]> NOTIFY=NEVER{code}
> In this case James should
> * remember the given DSN options (NOTIFY, ORCPT, RET, ENVID) for each
> recipient, and
> * provide the same options when relaying the mail to remote servers via the
> RemoteDelivery mailet.
> (The DSN options should be accessible to other interested mailets as well,
> e.g. for bounce processing.)
> Possibly related issues:
> https://issues.apache.org/jira/browse/JAMES-322
> https://issues.apache.org/jira/browse/JAMES-362
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
