[
https://issues.apache.org/jira/browse/JAMES-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255004#comment-17255004
]
ASF GitHub Bot commented on JAMES-3477:
---------------------------------------
chibenwa commented on pull request #281:
URL: https://github.com/apache/james-project/pull/281#issuecomment-751347054
> Do you know what the 'optimized' raw access you speak of is?
It was accessing the shared underlying MimeMessageWrapper to get an
InputStream out of it (instead of writeTo + OutputSream)
> where and when it used to occur ?
It happens in most 'core' aware classes, anytime we want to have an
InputStream version of the message.
> I'm curious because dispose would set the ref to underlying to null but
if the 'optimized' access already had the reference it shouldn't have failed...
See https://github.com/apache/james-project/pull/280#commitcomment-45090717
The message held by the reference was exposed unprotected. Thus: when you
have a COW message, leveraging the benefits of MimeMessageWrapper was unsafe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> MimeMessageCopyOnWriteProxy is not thread safe
> ----------------------------------------------
>
> Key: JAMES-3477
> URL: https://issues.apache.org/jira/browse/JAMES-3477
> Project: James Server
> Issue Type: Wish
> Reporter: Benoit Tellier
> Priority: Major
>
> https://www.mail-archive.com/[email protected]/msg69221.html
> &
> https://github.com/jeantil/james-project/commit/c0354ea21c5b0a8f6d46e9919f7db0d97db9eb23
> proves there is a concurrency issue in MimeMessageCopyOnWriteProxy class that
> we need to investigate.
> It causes our test suite to be flacky.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
