[
https://issues.apache.org/jira/browse/JAMES-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256991#comment-17256991
]
ASF GitHub Bot commented on JAMES-3477:
---------------------------------------
jeantil commented on a change in pull request #282:
URL: https://github.com/apache/james-project/pull/282#discussion_r550480120
##########
File path:
server/mailet/mailetcontainer-camel/src/test/java/org/apache/james/mailetcontainer/impl/JamesMailetContextTest.java
##########
@@ -289,7 +291,7 @@ public void
bounceShouldNotFailWhenNonConfiguredPostmaster() throws Exception {
.name("mail1")
.sender(mailAddress)
.addRecipient(mailAddress)
- .mimeMessage(MimeMessageUtil.defaultMimeMessage())
+ .mimeMessage(MimeMessageUtil.mimeMessageFromBytes("header:
value\r\n".getBytes(UTF_8)))
Review comment:
considering how many times MimeMessageUtil.mimeMessageFromBytes("header:
value\r\n".getBytes(UTF_8) is repeated over multiple tests, it could be worth a
constant.
I think FakeMail is a good candidate to hold the constant or a factory
method + constant if we want to avoid sharing the byte[]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> MimeMessageCopyOnWriteProxy is not thread safe
> ----------------------------------------------
>
> Key: JAMES-3477
> URL: https://issues.apache.org/jira/browse/JAMES-3477
> Project: James Server
> Issue Type: Wish
> Reporter: Benoit Tellier
> Priority: Major
>
> https://www.mail-archive.com/[email protected]/msg69221.html
> &
> https://github.com/jeantil/james-project/commit/c0354ea21c5b0a8f6d46e9919f7db0d97db9eb23
> proves there is a concurrency issue in MimeMessageCopyOnWriteProxy class that
> we need to investigate.
> It causes our test suite to be flacky.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
