[ 
https://issues.apache.org/jira/browse/JAMES-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317698#comment-17317698
 ] 

Daniel Gultsch commented on JAMES-3556:
---------------------------------------

To be clear I’m talking about the variable name in the URI template not about 
the request parameter name

 
{code:json}
 "eventSourceUrl": 
"https://j.ltt.rs/eventSource?types={types}&closeAfter={closeAfter}&ping={ping}";
 {code}
 

The important fix here \{closeAfter}->\{closeafter}

What the request parameter is called doesn’t matter.

 

The PR looks like it is touching the request parameter name and leaving the 
template variable name untouched. (But I might be missing how and where the 
template variable names are generated; In that case sorry for the noise.)

> JMAP eventUrl s/closeAfter/closeafter/
> --------------------------------------
>
>                 Key: JAMES-3556
>                 URL: https://issues.apache.org/jira/browse/JAMES-3556
>             Project: James Server
>          Issue Type: Bug
>          Components: JMAP
>    Affects Versions: master
>            Reporter: Daniel Gultsch
>            Assignee: Antoine Duprat
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> According to rfc6570 section 2.3 variable names in URI templates are case 
> sensitive.
>  
> RFC 8620 section 2 defines a variable closeafter for the eventSourceUrl.
>  
> James calls this variable closeAfter
>  
> (I admit that this is confusing as other parts of the spec use camelCase for 
> the variable names)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to