Hi Benoit,
At the moment I'm working from
https://github.com/ff-wl/james-project/tree/netty4 - but I'd really
appreciate a branch which combines all the netty4 work :-)
You were right - I forgot to submit my code review! Can see comments
here: https://github.com/apache/james-project/pull/886
I'm working on a commit at the moment to fix some/all of the review
comments I made - you just tell me what you like and what you don't. Please
just let me know the git HEAD to use and where to send the pull request to.
Thanks in advance,
Glennos
On Mon, 21 Mar 2022 at 13:22, Benoit TELLIER <btell...@linagora.com> wrote:
>
> On 21/03/2022 06:46, Glennos wrote:
> > Follow up question: when are you planning on merging 'JAMES-3715: Upgrade
> > to Netty 4.1' to master and releasing?
> Good question!
>
> As explained in https://github.com/apache/james-project/pull/886 We are
> waiting to have a grren build on
> https://github.com/apache/james-project/pull/908 too as it fixes much of
> the issues we spotted with the original contribution.
>
> To be fairly honest I likely should merge the two PRs in one to make
> this matter of fact explicit.
>
> Regards
> >
> >
> > On Mon, 21 Mar 2022 at 10:41, Glennos <glennos...@gmail.com> wrote:
> >
> >> Hi all,
> >>
> >> I'm new to the project - my name is Glennos, and I've been chatting with
> >> @chibenwa over https://gitter.im/apache/james-project - however he
> >> suggested I join the mailing list, so that's what I'm doing! So hi
> everyone!
> >>
> >> I'd like to contribute to this pull request: JAMES-3715: Upgrade to
> Netty
> >> 4.1;
> >> https://github.com/apache/james-project/pull/886
> >> https://issues.apache.org/jira/projects/JAMES/issues/JAMES-3715
> >>
> >> I've reviewed the changes made so far - and I've left a whole bunch of
> >> review comments at the end of
> >> https://github.com/apache/james-project/pull/886
> >> (however you seem to need to be a project maintainer or maybe just
> >> logged in to see them)
> >>
> >> Feel free to suggest if you want me to make all the suggested changes -
> or
> >> even none - doesn't especially bother me. However I have noted some
> minor
> >> bugs/potential issues that I do think would be valuable to fix.
> >>
> >> I'd also like to improve the 'Encryption' class to support *both*
> >> SSLContext and SslContext. I've already implemented this and other
> fixes, *just
> >> need to know where to contribute them*;
> >> 1. *It would be handy if someone could create a 'netty4' branch or
> >> similar on https://github.com/apache/james-project/
> >> <https://github.com/apache/james-project/>*
> >> 2. Alternatively should I fork or can I directly contribute to
> >> https://github.com/ff-wl/james-project/tree/netty4 ? (not preferred,
> much
> >> rather we all contribute to a branch on the main
> 'apache/james-project/')
> >>
> >> Thanks in advance,
> >>
> >> Regards,
> >>
> >> Glennos
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
> For additional commands, e-mail: server-dev-h...@james.apache.org
>
>
