This is an automated email from the ASF dual-hosted git repository. chibenwa pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-jspf.git
commit cb654cc298d407f7bd1dd9248e7dbd5010311d2c Author: Benoit TELLIER <[email protected]> AuthorDate: Sat Apr 25 22:41:03 2026 +0200 [FIX] Do not fail the test suite on unreachable DNS service --- .../test/java/org/apache/james/jspf/helpers/FakeResolverTest.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/resolver/src/test/java/org/apache/james/jspf/helpers/FakeResolverTest.java b/resolver/src/test/java/org/apache/james/jspf/helpers/FakeResolverTest.java index 6798dde..c946188 100644 --- a/resolver/src/test/java/org/apache/james/jspf/helpers/FakeResolverTest.java +++ b/resolver/src/test/java/org/apache/james/jspf/helpers/FakeResolverTest.java @@ -50,6 +50,7 @@ import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertThrows; import static org.junit.Assert.assertTrue; +import static org.junit.Assume.assumeFalse; public class FakeResolverTest { private static final Logger logger = LoggerFactory.getLogger(FakeResolverTest.class); @@ -117,6 +118,7 @@ public class FakeResolverTest { @Test public void shouldMatchResolvedTXT() throws IOException { + assumeFalse("No reachable external name for TXT, skipping", externalNameTXT.isEmpty()); recordsMatch(Name.fromString(externalNameTXT), Type.TXT); } @@ -135,6 +137,7 @@ public class FakeResolverTest { @Test public void shouldMatchResolvedMX() throws IOException { + assumeFalse("No reachable external name for MX, skipping", externalNameMX.isEmpty()); recordsMatch(Name.fromString(externalNameMX), Type.MX); } @@ -158,6 +161,7 @@ public class FakeResolverTest { @Test public void shouldMatchResolvedNS() throws IOException { + assumeFalse("No reachable external name for NS, skipping", externalNameNS.isEmpty()); recordsMatch(Name.fromString(externalNameNS), Type.NS); } @@ -175,21 +179,25 @@ public class FakeResolverTest { @Test public void shouldMatchResolvedCNAME() throws IOException { + assumeFalse("No reachable external name for CNAME, skipping", externalNameCNAME.isEmpty()); recordsMatch(Name.fromString(externalNameCNAME), Type.CNAME); } @Test public void shouldMatchResolvedA() throws IOException { + assumeFalse("No reachable external name for A, skipping", externalNameA.isEmpty()); recordsMatch(Name.fromString(externalNameA), Type.A); } @Test public void shouldMatchResolvedAAAA() throws IOException { + assumeFalse("No reachable external name for AAAA, skipping", externalNameAAAA.isEmpty()); recordsMatch(Name.fromString(externalNameAAAA), Type.AAAA); } @Test public void shouldResolveExternallyLegacy() throws IOException { + assumeFalse("No reachable external name for CNAME, skipping", externalNameCNAME.isEmpty()); String domain = "fakeresolver.zone"; FakeResolver fakeResolver = new FakeResolver(new SimpleResolver()); fakeResolver.fromZoneFile(domain, DNSZONEFILE); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
