Dan,
Indeed. I'll care of the new CR and integration as soon as we make
decision to integrate this patch.
-Dmitry
On 2011-09-12 17:37, Daniel D. Daugherty wrote:
Just an administrative FYI. Bug ID 6941923 has already been
used to push a fix to the HotSpot repo:
http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/2a241e764894
so it cannot be used again in the HotSpot repo. If this work
is going to move forward, then a new bug ID will be needed.
Dan
On 9/11/11 7:18 PM, Yasumasa Suenaga wrote:
Hi,
I'm using "logrotate" tool on RHEL for various log rotation.
Now, HotSpot has gclog rotation function for log size base.
However, I need to rotate gc log synchronizing with logrotate tool.
So, I've made a patch for executing gclog rotation from external tool.
* Changes in HotSpot (hotspot.patch):
* gclog rotation request is received via AttachListener.
* logrotation function ( rotatingFileStream::rotate_log() ) has
1 parameter. It's determined that gclog rotation is forced or not.
* HotSpot allows "GCLogFileSize == 0" . Because we can rotate gclog
via external tool.
* Changes in JDK (jdk.patch):
* gclog rotation is invoked via "jinfo" command with "-rotategclog"
option.
* With "-rotategclog -force" option, gclog is rotated mandatorily.
* "jinfo" is executed "rotategclog" command in AttachListener on
target JVM.
I've attached these patch in this email. Please check it.
I would like to contribute this patch, and I hope to apply this patch to
JDK 6 / 7 / 8.
Please cooperate.
Best regards,
Yasumasa
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
