Looks good! /Staffan
On 23 maj 2012, at 19:44, Rob McKenna wrote: > Hi folks, > > David Holmes suggested a rewrite of the original bug (7168110) so I've put > together the following: > > http://cr.openjdk.java.net/~robm/7171184/webrev.01/ > > It will narrow down the cause of the error and return a more specific message > when there is a problem attaching jstack to a process created in another > session. > > Let me know what you think, > > -Rob > > -------- Original Message -------- > Subject: Codereview request for 7168110: Misleading jstack error message > Date: Thu, 17 May 2012 16:50:01 +0100 > From: Rob McKenna <rob.mcke...@oracle.com> > To: serviceability-dev@openjdk.java.net > <serviceability-dev@openjdk.java.net> > > Hi folks, > > A straightforward enough fix for an issue whereby windows sees fit to > return a cryptic error message when attempting to run jstack on a > process created in another terminal session. > > As per the webrev, see the remarks section at: > > http://msdn.microsoft.com/en-us/library/ms682437%28VS.85%29.aspx > > Webrev at: > > http://cr.openjdk.java.net/~robm/7168110/webrev.01/ > > Thanks! > > -Rob
