I do not see any issues with that webrev.
Looks good.
Thanks,
Serguei
On 5/23/12 12:59 PM, Daniel D. Daugherty wrote:
Greetings,
This is a hotspot code review request for the second of a pair of
Full Debug Symbols gobjcopy work arounds on Solaris. The first
hotspot FDS gobjcopy work around was reviewed using bug 7165060
and that fixed the dtrace test failures.
The gobjcopy utility also crashes due to empty sections with the
SHF_ALLOC flagset on Solaris X64 objects. This causes build
failures.
The first new temporary work around tool is add_gnu_debuglink
and it was added by 7165060.The second new temporary work around
tool is:
fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty
sections in ELF objects.
These temporary work arounds are only needed until the proper
Solaris 10 Update 6 patches are made available. The two patches
are independent of one another which is why there are two
separate temporary work arounds. However, we're putting the
temporary work arounds in place because the 7u6/HSX-23.2 project
window is closing fast.
Here is the webrev URL for the HSX-24 version:
http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/
This fix will also be backported to 7u6/HSX-23.2 and I expect the
changes to virtually identical.
Thanks, in advance, for any reviews!
Dan
