Jaroslav, The fix looks good for me.
-Dmitry On 2012-10-10 22:25, Jaroslav Bachorik wrote: > On Wed 10 Oct 2012 05:42:43 PM CEST, Dmitry Samersoff wrote: >> Jaroslav, >> >> Not able to open it as a webrev - only list of files. >> >> E-mail me the webrev and I'll put it to >> file:///opt/src/jdks/openjdk-patches/webrevs/JDK-6809322.zip > >> cr.openjdk.net/~dsamersoff/sponsorship/jbachorik/NNNNN > > Attaching... Thanks. I didn't want to put the webrevs on rapidshare or > the likes and github seemed like a nice choice. Unfortunately it is not > possible to view raw files :( > > -JB- > >> >> -Dmitry >> >> >> On 2012-10-10 18:39, Jaroslav Bachorik wrote: >>> I am sorry for the webrev URL - a stale clipboard :( >>> >>> The correct webrev URL is >>> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6809322 >>> >>> -JB- >>> >>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>> I am looking for a review and a sponsor. >>>> >>>> The issue is about some javax.management.timer.Timer notifications not >>>> being received by the listeners if the notifications are generated rapidly. >>>> >>>> The problem is caused by ConcurrentModificationException being thrown - >>>> the exception itself is ignored but the dispatcher logic is skipped. >>>> Therefore the currently processed notification gets lost. >>>> >>>> The CME is thrown due to the Timer.timerTable being iterated over while >>>> other threads try to remove some of its elements. Fix consists of >>>> replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap >>>> which handles such situations with grace. >>>> >>>> The patch webrev is available @ >>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>> >>>> Thanks, >>>> >>>> -JB- >>>> >>> >> >> > > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ...