On 01/18/2013 04:58 PM, Rickard Bäckman wrote: > http://cr.openjdk.java.net/~rbackman/8006563/
Looks good to me (not a Reviewer), modulo: a) Are we sure this thing is not acquired in some weird way, i.e. through JVMTI, SA, or whatnot? b) The formatting of the predicate does not follow it's structure, I think it should be: ... this != Interrupt_lock && !(this == Safepoint_lock && contains(locks, Terminator_lock) && SafepointSynchronize::is_synchronizing())) { This way it is more obvious SafepointSynchronize::is_synchronizing()) is the !(...) group. -Aleksey.