Hi Serguei,
I have two queries:
In MemberNameTable::add_member_name why do you not have
assert_locked_or_safepoint(MemberNameTable_lock) ?
In MethodHandles::init_field_MemberName you deleted:
304 InstanceKlass::cast(field_holder())->add_member_name(mname);
apart from this seeming to be unrelated to the rest of the fix, does its
removal make the previous 8 lines of comment unnecessary? (I confess I
don't understand the relationship between the comment and the code anyway.)
Thanks,
David
On 24/05/2013 9:19 AM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
bug: http://bugs.sun.com/view_bug.do?bug_id=8014288
jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/
Summary:
The fix of the 8008511 introduced a performance regression for the
Nashorn tests.
The fix is to use method_idnum() for direct indexing into the
MemberNameTable
that replaces a linear search caused the regression.
No new regression test is needed as the Nashorn tests show the
performance is back to normal.
Testing:
The vm/mlvm and Nashorn tests
Thanks,
Serguei
