Was this a request for review? In that case: looks good. If it was a request for someone to fix this, let me know and I'll do it.
/Staffan On 11 jun 2013, at 21:20, Alan Bateman <alan.bate...@oracle.com> wrote: > > This test was liberated recently [1] but unfortunately it's failing again. > The typical failure now is: > > Unrecognized option: -ea -J-esa -J-Xmx512m > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. result: > Failed. Execution failed: exit code 1 > > The problem is that TESTTOOLVMOPTS is quoted when jtreg is run with several > options then they appear as one. The fix is trivial: > > -${JAR} "${TESTTOOLVMOPTS}" cvfm ${AGENT}.jar ${AGENT}.mf ${AGENT}*.class > ${OTHER}*.java > +${JAR} ${TESTTOOLVMOPTS} cvfm ${AGENT}.jar ${AGENT}.mf ${AGENT}*.class > ${OTHER}*.java > > and that gets it passing again. > > -Alan > > [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f18337edd201