On 14/06/2013 20:49, Dan Xu wrote:
Hi,
I have a simple fix to clean up the new javac overrides warnings in
NotificationBroadcasterSupport.java file. Please help review it. Thanks!
webrev: http://cr.openjdk.java.net/~dxu/8016592/webrev.00/
<http://cr.openjdk.java.net/%7Edxu/8016592/webrev.00/>
bug: http://bugs.sun.com/view_bug.do?bug_id=8016592
-Dan
I don't know this code but it looks to me that ListenerInfo.equals
doesn't really need to check if the object is a WildcardListenerInfo.
That is, I assume there aren't ListenerInfo instances that have a null
filte and handback==null but aren't a WildcardListenerInfo. In any case,
the hashCode looks fine.
WildcardListenerInfo looks okay too although for consistency then it
should probably use super.hashCode() so it's more obvious when checking
it against the equals method.
-Alan.
