On 19/06/2013 20:05, Kurchi Hazra wrote:
On 6/17/2013 1:01 PM, Chris Hegarty wrote:
On 06/17/2013 08:08 PM, Kurchi Hazra wrote:
- Maybe a webrev helps:
http://cr.openjdk.java.net/~khazra/8016576/webrev.01/
<http://cr.openjdk.java.net/%7Ekhazra/8016576/webrev.01/>
Looks fine, but trivially remove the unnecessary null check in equals
before pushing. If 'o instanceof XObject', then it cannot be null.
Similar for SDE.equals
- For XObject I am checking if object is null which is a member of
XObject (and not o) -
Apologies, you are correct. Since I'm unlikely to ever look at this
code again ;-) I'll refrain from suggesting to rename the variables
to something less obscure/confusing.
Thanks Chris. This is what I am pushing finally:
http://cr.openjdk.java.net/~khazra/8016576/webrev.02/
<http://cr.openjdk.java.net/%7Ekhazra/8016576/webrev.02/>
This looks good to me.
-Alan
