Looks good to me. /R
On Jul 17, 2013, at 12:25 PM, Markus Grönlund wrote: > Hi again, > > Trying again, could I please have a couple of reviews for this? > > Many thanks > Markus > > From: Markus Grönlund > Sent: den 16 juli 2013 17:48 > To: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net > Subject: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type > (hsx24) > > Greetings, > > Kindly asking for reviews for the following change in hsx24: > > Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547 > > Webrev: http://cr.openjdk.java.net/~mgronlun/8020547/webrev01/ > > tracetypes.xml will declare a STRING type in order to support larger strings > compared to existing UTF8 type (which is limited to a length of u2, max > 65535 chars). > > I have also removed some stale comments. > > Thank you > Markus
