Hi Alan,
Added a status bar to the plug-in. It's hidden by default, not to waste
screen estate.
http://cr.openjdk.java.net/~egahlin/6696975_2/
If you could have a look at this small fix too,
RFR (XS): 7042707: Un-needed mnemonic in JConsole resource file
http://cr.openjdk.java.net/~egahlin/7042707/
Thanks for all your reviews
Erik
Erik Gahlin skrev 2013-08-13 16:39:
Alan Bateman skrev 2013-08-12 15:16:
On 06/08/2013 19:53, Erik Gahlin wrote:
Please review this change.
ThreadMXBean#setThreadCpuTimeEnabled(true) assumes read-write access
to the underlying JVM, but if read-access is only available plug-in
will fail and throw an exception.
http://monaco.us.oracle.com/detail.jsf?cr=6696975
Unexpected exceptions occurring in JConsole are taken care of by
6696970, but plug-in should still handle read-only access
gracefully, as it today does if functionality is not supported by
JVM. This can be important if plug-in is used by other programs.
Webrev:
http://cr.openjdk.java.net/~egahlin/6696975/
Is there any way for the error messages to be printed on the JTop
panel rather than printing them to stderr where they might not be seen?
There is no way today, but a status bar could be added at the bottom.
I will look into it
Thanks
Erik
-Alan
