On 8/15/2013 5:35 AM, Erik Gahlin wrote:
Mandy Chung skrev 2013-08-12 20:49:
Should L358, 359, 388 need to be guarded to validate the result value?
paintBorder and fillRect accepts negative and zero values so there
will not be an exception.
What happens if the variable h evaluated at L358 is non-zero? If the
Swing components handle invalid values, would you think fixing the
calculateTickInterval method to handle invalid parameter (namely
non-zero w value) would be appropriate?
I'm including Leif who may have advice on how to handle resizing. I
think there would be some best practices that you can follow.
Mandy
Erik
Mandy
On 7/29/2013 1:02 PM, Erik Grahlin wrote:
Please review a small change:
Description:
Switch to the Threads tab and try shrinking the window. When the window
width becomes smaller than some particular size, an exception is printed
to the terminal on every window update.
Bug:
http://monaco.us.oracle.com/detail.jsf?cr=6358357
Webrev:
http://cr.openjdk.java.net/~egahlin/6358357/
<http://cr.openjdk.java.net/%7Eegahlin/6358357/>
Testing:
Verified that no exceptions occur.
A sponsor is needed.
Thanks
Erik
