Peter, Looks good for me.
But I would prefer to have brackets around c != NULL -Dmitry On 2013-09-17 19:44, Peter Allwin wrote: > Hello! > > Please review this small fix for an issue where jio_snprintf may be > called with a null argument causing SEGV on Solaris. This can occur if > to_string is called on a GenDCmdArgument<char*> with no default value. > > cr: http://cr.openjdk.java.net/~allwin/7196151/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-7196151 > > > serviceability/ParserTest.java reproduces this issue and the fix has > been verified with this test. > > > Thanks! > /peter -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
