Ivan, I'm not sure this test adds anything to the current testing. As far as I understand, the test checks if jdb is in a location that contains space and then tries to start it. If the path does not contain space it does nothing. We already have many tests that launch jdb, regardless of space in the path, and it thus looks to me like this new test does not add anything to the testing.
If you want to really verify the bug you need to move jdb into a location that actually has a space in it and then launch it. Please let me know if I misunderstood your test. Thanks, /Staffan On 24 sep 2013, at 08:12, Ivan Gerasimov <ivan.gerasi...@oracle.com> wrote: > Hello all! > > Would you please help review a new regression test? > This is related to the fix for 8014676 (jdb could not run under Windows, if > its path contained a space). > > The test simply checks, if the path to the tested jdk contains a space and > exits, if it does not. > Otherwise it tries to run the debugger. With the bug 8014676, the debugger > will report IOExeption thrown. > > The complicated part is that with the presence of no error, the debugger will > not exit, but wait for the user command instead. > To prevent it, I pass a nonexistent option to the debuger. Thus it must fail > with an error message. > > Here's the webrev: http://cr.openjdk.java.net/~igerasim/8014792/0/webrev/ > > Here's the bug: http://bugs.sun.com/view_bug.do?bug_id=8014792 > > Here's the fix for 8014676: > http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/81c449fd18fe > > Sincerely yours, > Ivan Gerasimov
