Hi Jaroslav, The "ERROR:" prefix is hard-coded in error_messages.c and is not subject to localisation etc. so I think performing a case-sensitive compare seems reasonable - although if you feel strongly about it I can definitely change it.
Thanks for the review! /peter On Oct 4, 2013, at 1:41 PM, Jaroslav Bachorik <[email protected]> wrote: > Looks fine. Just a thought - wouldn't it make sense to check for the error > message disregarding the case? > > -JB- > > On 4.10.2013 13:29, Staffan Larsen wrote: >> Looks good! >> >> Thanks, >> /Staffan >> >> On 4 okt 2013, at 13:13, Peter Allwin <[email protected]> wrote: >> >>> Hello! >>> >>> Looking for reviews for this very simple fix to a JDK test, where warnings >>> in stderr could cause the test to fail. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8014446 >>> CR: http://cr.openjdk.java.net/~allwin/8014446/webrev.00/ >>> >>> >>> Thanks! >>> /peter >> >
