On 23/10/2013 7:38 PM, Dmitry Samersoff wrote:
David,

SA doesn't support live process debugging on OSX, so this file is not
compiled during libsaproc.dynlib build.

But yes, if I enable compilation of this file during OSX build it fails
as well, so this fix is required to go froward.

Thanks for clarifications that this code is not used on OSX - so another case of the OSX port blindly copying linux code. I wonder how many more such issues remain to be uncovered. :(

May I consider you as a reviewer?

Yes as I said in my email "Reviewed" :)

David

-Dmitry


On 2013-10-23 06:37, David Holmes wrote:
On 21/10/2013 7:50 PM, Dmitry Samersoff wrote:
Hi Everybody,

Please review a small fix.

http://cr.openjdk.java.net/~dsamersoff/JDK-8026950/webrev.01/

I don't understand why this is only a compile error on "open hotspot"?
PT_CONTINUE seems to be the necessary value for OSX and other BSD
systems. Do some systems have an alias in place?

Reviewed.

David

-Dmitry



Reply via email to