Out of curiosity, what is the reason for the rename? I ask because we use Basic and similar names in many areas. Also anything in the test tree should be a test.
-Alan. On 20/11/2013 13:47, Mattias Tobiasson wrote:
Hi, Could you please review this fix. Summary of changes: 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. 2. Ported the following bash scripts to java: BasicTests.sh -> TestBasic.java PermissionTests.sh -> TestPermission.java ProviderTests.sh -> TestProvider.java 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: BasicsTest.java -> TestBasicImpl.java PermissionTest.java -> TestPermissionImpl.java ProviderTest.java -> TestProviderImpl.java 4. Added some utility functions to jdk/testlibrary. 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. Thanks, Mattias Webrev: http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-6461635
