Staffan, Chris,

Thanks for the review.

On 11/20/2013 3:59 AM, Chris Hegarty wrote:
Mandy,

The changes look ok to me, and the approach of adding additional diagnostic information makes sense.

Trivially, you can remove 'trace', as I don't think it is being used any more.


Will remove it before I push.

Mandy

-Chris.

On 19/11/13 23:12, Mandy Chung wrote:
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028647/webrev.00/

This patch turns the trace on by default and also add the
instrumentation to print the safepoint count to help troubleshooting the
test failure.

test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java is no
longer reproducible on jdk8 b109.   GetSafepointSyncTime.java should be
removed from the ProblemList.txt.    This still fails with 7u45 and so I
want to backport this change to 7u-dev.   There might be a hotspot fix
in jdk8 that resolves the zero safepoint sync time issue for further
investigation.

thanks
Mandy


Reply via email to