The changes look good, although the tests are *very* basic. Probably does not 
make sense to improve the tests as part of this change, though.

/Staffan

On 13 jan 2014, at 11:40, Yekaterina Kantserova 
<[email protected]> wrote:

> Hi,
> 
> Could I please have a review of this fix.
> 
> I've rewritten the shell tests sun/tools/jstack and sun/tools/jmap in pure 
> Java to get rid of environmental problems. The com/sun/tools/attach tests has 
> already been fixed.
> 
> 
> Webrev:
> http://cr.openjdk.java.net/~ykantser/6380601/webrev.00/
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-6380601
> 
> 
> Thanks,
> Katja

Reply via email to