Looks good to me. Makes sense to only count classes defined by the loader.
David
On 30/01/2014 7:21 AM, Jaroslav Bachorik wrote:
Could I have a second HS reviewer for this, please?
-JB-
On 17.12.2013 14:34, Jaroslav Bachorik wrote:
Thanks! I guess I will be needing a second reviewer since the change is
in the hotspot repo.
-JB-
On 17.12.2013 14:32, Staffan Larsen wrote:
Looks good!
Thanks,
/Staffan
On 17 dec 2013, at 12:54, Jaroslav Bachorik
<[email protected]> wrote:
Please, review the following fix.
Issue : https://bugs.openjdk.java.net/browse/JDK-6656031
Webrev: http://cr.openjdk.java.net/~jbachorik/6656031/webrev.00
The issue is caused by using SystemDictionary.ClassAndLoaderVisitor
to traverse the dictionary classes to get the numbers of the loaded
classes per classloader. This visitor will visit all the combinations
of a particular class and all its classloaders - the defining CL +
all initiating CLs. This will cause completely wrong numbers to be
reported.
The solution is to use SystemDictionary.ClassVisitor which walks only
over the loaded classes (each class exactly once) and extract the
defining CL from the visited Klass.
Thanks,
-JB-
