Hi Jesper,
I browsed the 7u60 back port and it looks fine as far as I can tell.
I did not look at the 8u20 back port since I don't think you need a
review if it applied cleanly.
One small detail that you probably should not change for these back
ports but that I should have noticed in the original patch is the error
message in Arguments::verify_MinHeapFreeRatio(). It says
"MinHeapFreeRatio must have a value between 0 and 100" but in fact we
only allow 0-99.
I guess this is probably not worth fixing. Not even for 9. But I just
wanted to mention it since I should have caught it in the original review.
Thanks,
Bengt
On 2/4/14 10:17 AM, Jesper Wilhelmsson wrote:
Hi,
The patch from jdk9/hs-gc to make MinHeapFreeRatio and
MaxHeapFreeRatio manageable flags and supported in ParallelGC applied
cleanly to jdk8u/hs-dev.
hsx/jdk7u60 required some manual labor to patch since the argument
parsing code had moved around, but the relevant logic was untouched so
I didn't have to change anything in the new code. For 7 I omitted some
of the minor cleanups that was done in the original patch.
Webrev for 7: http://cr.openjdk.java.net/~jwilhelm/8028391/webrev.7u60/
Webrev for 8: http://cr.openjdk.java.net/~jwilhelm/8028391/webrev.8u20/
(The 8u20 webrev is identical with the final version for 9.)
So kindly approve this change for backport to jdk8u20 and jdk7u60.
The bugs:
jdk9: https://bugs.openjdk.java.net/browse/JDK-8028391
jdk8: https://bugs.openjdk.java.net/browse/JDK-8033209
jdk7: https://bugs.openjdk.java.net/browse/JDK-8028720
Reviews in this thread:
http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2014-January/009187.html
The jdk9 changeset:
http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/rev/44315152d434
Thanks,
/Jesper
