On 4/24/14 8:09 AM, Staffan Larsen wrote:
I can see version numbers bumped in 
com/sun/tools/jdi/VirtualMachineManagerImpl.java as well as in 
src/share/back/VirtualMachineImpl.c. Are there other places that need fixing?

No. I redid my searches of the patch and I see them now.

This is what I get for trying to do a quick search and post a quick
comment without having reviewed the whole webrev. I don't normally
do things that way and I apologize for the noise.

A CCC has been filed and approved.

I would have mentioned that a CCC has been approved and probably
included a line apologizing that the CCC process is still not
accessible external to Oracle.

Dan


Thanks,
/Staffan

On 24 apr 2014, at 15:57, Daniel D. Daugherty <[email protected]> 
wrote:

Jaroslav,

It looks like you are adding APIs here so you'll need to bump at
least the minor version numbers here. Also, I think you need a
CCC request for this work.

Dan


On 4/24/14 6:52 AM, Jaroslav Bachorik wrote:
Please, review the following patch:

Issue : https://bugs.openjdk.java.net/browse/JDK-8031195
Webrev: http://cr.openjdk.java.net/~jbachorik/8031195/webrev.04

With JDK8 it became possible to have methods with implementation in interfaces 
- static and default interface methods. However the JDI and JDWP were not 
updated to reflect these capabilities so it is not currently possible to invoke 
a static or default interface method programatically from the debugger.

This patch adds support for static and default interface methods to JDI, JDWP 
and JDB.

Thanks,

-JB-

Reply via email to