Looks good! Thanks, /Staffan
On 9 maj 2014, at 12:43, Yekaterina Kantserova <yekaterina.kantser...@oracle.com> wrote: > Hi, > > The version b09 of JTreg which contains > https://bugs.openjdk.java.net/browse/CODETOOLS-7900178 has been promoted. So > it seems to be time to push the fix for JDK-8034960. I've made a new webrev > to be sure the changes fit in in the latest jdk9 source. The webrev can be > found here: cr.openjdk.java.net/~ykantser/8034960/webrev.01. > > Thanks, > Katja > > > > On 03/25/2014 01:14 PM, Staffan Larsen wrote: >> I’ve looked at a random sample of these changes and they look ok. >> >> Since some of the changes are in non-serviceability code I have also added >> core-libs to the review thread. >> >> I’m sure you know this, but for the record: please don’t push this until >> jtreg with the fix has been promoted. >> >> Thanks, >> /Staffan >> >> On 25 mar 2014, at 13:07, Yekaterina Kantserova >> <yekaterina.kantser...@oracle.com> wrote: >> >>> Hi, >>> >>> Could I please have a review of this fix. >>> >>> webrev: http://cr.openjdk.java.net/~ykantser/8034960/webrev.00/ >>> bug: https://bugs.openjdk.java.net/browse/JDK-8034960 >>> >>> When using @library in a JTreg test even @build need to be specify for all >>> library files used by the test. If @build is not specified it can lead to >>> intermittent failures when running tests concurrently, since javac implicit >>> compilation and @library and -concurrency don't play well together. >>> >>> Verified locally since no JTreg with fix has been promoted yet. >>> >>> >>> Thanks, >>> Katja >
