Reviewed.
Best regards,
Vladimir Ivanov
On 6/30/14 11:42 AM, Staffan Larsen wrote:
Can I have a Review of this change?
Thanks,
/Staffan
On 25 jun 2014, at 08:53, Staffan Larsen <staffan.lar...@oracle.com> wrote:
On 24 jun 2014, at 14:45, Igor Ignatyev <igor.ignat...@oracle.com> wrote:
Staffan,
1. '@ignore' should be followed by CR numbers
Good catch - I have fixed that below.
2. I doubt that TestVM* failures are related to JDK-8032226. these tests don't
use SA agent, they rather fail due to JDK-8031978
You are right. There seems to be some confusion in the RULEs for these two CRs
so they match incorrectly. I have added 8031978 or 8032226 as appropriate to
the @ignores.
/Staffan
diff --git a/test/compiler/ciReplay/TestSA.sh b/test/compiler/ciReplay/TestSA.sh
--- a/test/compiler/ciReplay/TestSA.sh
+++ b/test/compiler/ciReplay/TestSA.sh
@@ -26,6 +26,7 @@
##
## @test
## @bug 8011675
+## @ignore 8032226, 8031978
## @summary testing of ciReplay with using generated by SA replay.txt
## @author igor.ignat...@oracle.com
## @run shell TestSA.sh
diff --git a/test/compiler/ciReplay/TestVM.sh b/test/compiler/ciReplay/TestVM.sh
--- a/test/compiler/ciReplay/TestVM.sh
+++ b/test/compiler/ciReplay/TestVM.sh
@@ -26,6 +26,7 @@
##
## @test
## @bug 8011675
+## @ignore 8031978
## @summary testing of ciReplay with using generated by VM replay.txt
## @author igor.ignat...@oracle.com
## @run shell TestVM.sh
diff --git a/test/compiler/ciReplay/TestVM_no_comp_level.sh
b/test/compiler/ciReplay/TestVM_no_comp_level.sh
--- a/test/compiler/ciReplay/TestVM_no_comp_level.sh
+++ b/test/compiler/ciReplay/TestVM_no_comp_level.sh
@@ -26,6 +26,7 @@
##
## @test
## @bug 8011675
+## @ignore 8031978
## @summary testing of ciReplay with using generated by VM replay.txt w/o
comp_level
## @author igor.ignat...@oracle.com
## @run shell TestVM_no_comp_level.sh
Igor
On 06/24/2014 03:12 PM, Staffan Larsen wrote:
These tests keep being unstable in nightly testing (see JDK-8032226) so will
have to be quarantined.
Thanks,
/Staffan
diff --git a/test/compiler/ciReplay/TestSA.sh b/test/compiler/ciReplay/TestSA.sh
--- a/test/compiler/ciReplay/TestSA.sh
+++ b/test/compiler/ciReplay/TestSA.sh
@@ -26,6 +26,7 @@
##
## @test
## @bug 8011675
+## @ignore
## @summary testing of ciReplay with using generated by SA replay.txt
## @author igor.ignat...@oracle.com
## @run shell TestSA.sh
diff --git a/test/compiler/ciReplay/TestVM.sh b/test/compiler/ciReplay/TestVM.sh
--- a/test/compiler/ciReplay/TestVM.sh
+++ b/test/compiler/ciReplay/TestVM.sh
@@ -26,6 +26,7 @@
##
## @test
## @bug 8011675
+## @ignore
## @summary testing of ciReplay with using generated by VM replay.txt
## @author igor.ignat...@oracle.com
## @run shell TestVM.sh
diff --git a/test/compiler/ciReplay/TestVM_no_comp_level.sh
b/test/compiler/ciReplay/TestVM_no_comp_level.sh
--- a/test/compiler/ciReplay/TestVM_no_comp_level.sh
+++ b/test/compiler/ciReplay/TestVM_no_comp_level.sh
@@ -26,6 +26,7 @@
##
## @test
## @bug 8011675
+## @ignore
## @summary testing of ciReplay with using generated by VM replay.txt w/o
comp_level
## @author igor.ignat...@oracle.com
## @run shell TestVM_no_comp_level.sh
