On 8/26/14 3:58 AM, serguei.spit...@oracle.com wrote:
Dmitry,

I doubt, this webrev fixes the issue.
At least, I can't see it yet.

It looks like the assert is because the imagePath_ID or symbolPath_ID were not initialized properly.
But there is clear explanation yet how this could happen.
Sorry, a typo above. Wanted to say:
"But there is no clear explanation yet how this could happen."

Thanks,
Serguei

Maybe, the conclusion above was wrong, but some prove is needed and/or another possible root cause.

Also, Staffan is right, about killing the remote process.
The remote process has no relation to the fix.

Thanks,
Serguei


On 8/25/14 3:58 AM, Staffan Larsen wrote:
Dmitry,

Your changes look good (except missing spaces after commas). But what I do not 
understand is how this relates to the bug. The code in setImageAndSymbolPath() 
is not looking at the remote process, it’s just setting up data in the jstack 
process. How does killing the remote process affect this code? What am I 
missing?

/Staffan

On 21 aug 2014, at 14:56, Dmitry Samersoff<dmitry.samers...@oracle.com>  wrote:

Hi Everyone,

Please review small agent changes:

http://cr.openjdk.java.net/~dsamersoff/JDK-8054194/webrev.01/

Under windows, If jstack attempts to attach to java process that is
being killed by someone else, GetStaticObjectField might return NULL.

-Dmitry

--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


Reply via email to