hi Staffen, the change looks good, but could you please also change src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java
Thanks, Volker On Mon, Sep 8, 2014 at 2:45 PM, Staffan Larsen <staffan.lar...@oracle.com> wrote: > Thank you, all. > > On 8 sep 2014, at 14:39, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > > Hi Staffan, > > > > Looks good! > > > > -- daniel > > > > On 9/8/14 2:23 PM, Staffan Larsen wrote: > >> Please review this simple fix for some small issues in the attach code: > >> - Removed unused imports > >> - Removed unused fields > >> - Update @since for startManagementAgent() and > startLocalManagementAgent() since these were just backported to 1.8 > >> - Simplified a for-loop in a test > >> > >> bug: https://bugs.openjdk.java.net/browse/JDK-8057776 > >> webrev: http://cr.openjdk.java.net/~sla/8057776/webrev.00/ > >> > >> Thanks, > >> /Staffan > >> > > > >
