Thanks for the review Jaroslav! Could you please sponsor this patch and submit it?
repository /jdk9/dev/jdk I have made a simple grep search in /jdk/test/... and /hotspot/test/... and have not found any other test with the same error. Mattias ----- Original Message ----- From: jaroslav.bacho...@oracle.com To: serviceability-dev@openjdk.java.net Sent: Monday, October 27, 2014 6:45:49 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR 8061960: TestDaemonThread.java regularly fails due to exceeded timeout Thumbs up! I wonder whether there are still some other tests with similarly displaced switches... -JB- On 10/27/2014 04:21 PM, Mattias Tobiasson wrote: > Hi, > Could someone please review this simple fix. > The current version times out, because the timeout option is at the wrong > position on the command line. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8061960 > > Webrev: > http://cr.openjdk.java.net/~miauno/8060165/webrev.00/ > > Thanks, > Mattias >
# HG changeset patch # User mtobiass # Date 1414493131 -3600 # Tue Oct 28 11:45:31 2014 +0100 # Node ID 5b006524780430b3867a9cd83049256cf8524724 # Parent 784ba4639504b2d1e41ce648201f8f1bdaafe5d2 8061960: java/lang/instrument/DaemonThread/TestDaemonThread.java regularly fails due to exceeded timeout Summary: Move timeout parameter to correct place on command line Reviewed-by: jbachorik diff -r 784ba4639504 -r 5b0065247804 test/java/lang/instrument/DaemonThread/TestDaemonThread.java --- a/test/java/lang/instrument/DaemonThread/TestDaemonThread.java +++ b/test/java/lang/instrument/DaemonThread/TestDaemonThread.java @@ -28,7 +28,7 @@ * * @build jdk.testlibrary.* DummyAgent DummyClass TestDaemonThreadLauncher TestDaemonThread * @run shell ../MakeJAR3.sh DummyAgent - * @run main TestDaemonThreadLauncher /timeout=240 + * @run main/timeout=240 TestDaemonThreadLauncher * */ import java.io.File;
