Hi Filipp, looks good to me. thanks for fixing this.
Igor On 12/10/2014 04:48 PM, Filipp Zhinkin wrote:
Hi all, please review a fix for 8066862. Issue: testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java fails with RuntimeException: All Platform's methods with signature '():Z' should be tested Root cause: In order to prevent issues caused by the fact that some mutually exclusive predicates may return "true" on on the same platform (for example if isARM and isPPC will return true simultaneously) I decided to check in test if all Platform's methods with '():Z' signature were tested. Fix for 8039995 added new methods with "():Z" signature, but these methods were not marked in TestMutuallyExclusivePlatformPredicates as methods that should be ignored. Proposed fix: Mark newly added methods as ignored in TestMutuallyExclusivePlatformPredicates.java, add this test to sanity test group in order to run it in JPRT Bug id: https://bugs.openjdk.java.net/browse/JDK-8066862 Webrev: http://cr.openjdk.java.net/~fzhinkin/8066862/webrev.00/ Testing: manual & automated
