Hi Katja,

This request should probably go to core-libs as well.

Other than that I have just a few nits:

test/java/util/logging/TestLoggerWeakRefLeak.java

L57: if ("Logger".contains(args[0])) -> "Logger".equals(args[0]) ?
L127: // in LogManager.loggers that *arebeing* properly managed -> *are being*

callLoggerAndCount() and callAnonymousLoggerAndCount() are using the 'count' variable to always return 100. Could they be made to return a constant instead?


Cheers,

-JB-


On 12/16/2014 04:57 PM, Yekaterina Kantserova wrote:
Hi,

Could I please have a review of this fix.

bug: https://bugs.openjdk.java.net/browse/JDK-6977426
webrev: http://cr.openjdk.java.net/~ykantser/6977426/webrev.00/

java/util/logging/LoggerWeakRefLeak.sh and
java/util/logging/AnonLoggerWeakRefLeak.sh are merged and rewritten in
java. sun/tools/common/CommonTests.sh is removed because it doesn't test
the product but sun/tool/common library functionality.

Thanks,
Katja

Reply via email to